Photoswipe urls cannot be open by copying URL to another browser

iranzo commented 4 years ago

Mandatory Step

[x] I am using latest production release of Elegant

Recommended Step

[x] I have attached link to my blog source code repository, so that developers can try to reproduce the issue at the end
[x] I can't my source code but I have linked my pelican configuration files to help developers reproduce the issue

Description

Describe the bug Photoswipe URL's append some parameters to URL to identify gallery, pid, etc

https://next.elegant.oncrashreboot.com/gallery-embed-instagram-post#&gid=2&pid=1

If we copy/paste this url on another browser, not only the picture is not shown 'open', but also, the galleries are not shown in the article

To Reproduce Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

talha131 commented 4 years ago

This is becasue,

first the page loads
Then the create photo swipe gallery code is triggered
Then photoswipe does its magic

What do you expect to happen when you launch the URL? Why would you do it?

iranzo commented 4 years ago

If I see a picture that might be interesting in a pelican-elegant site, as user/visitor I want to be able to copy/paste/share with my phone or device an URL that will allow receiver to get the same page and picture displayed, i.e. getting the same gallery and picture open

talha131 commented 4 years ago

I see. Right now, I am not sure how it can be fixed. Nonetheless, I have added it to the roadmap.

We probably will have to leverage PhotoSwipe events or create our own.

Pelican-Elegant / elegant