Pelican-Elegant / elegant

Best theme for Pelican Static Blog Generator
https://elegant.oncrashreboot.com/
MIT License
293 stars 187 forks source link

treat the Tags view to the accordion style #59

Closed tshepang closed 10 years ago

tshepang commented 11 years ago

I find the accordion idea interesting, and I wonder why the Tags view isn't taking advantage of it?

tshepang commented 10 years ago

I hope I did not come off as rude... the testing Comment.

talha131 commented 10 years ago

GitHub's image uploading is not working, i'll upload image later.

You can use imgur.

I think I should go with this style

Category and date meta data are on far right, so this way it does not pollute the title of the article.

And could we make category names clickable with some color.

Hmm, don't you think this will affect the readability? Now you have two visible links on the same line. One article and other category. I don't think it will look elegant.

Yes I have one, but it's in Chinese language. I'm not sure whether it is useful to you.

It's useful for testing anyway :smile:

calfzhou commented 10 years ago

I do prefer my date to be cold yyyy-mm-dd. No need to bother with localisation there.

Elegant prints locale date, whatever it is that you have set in your configuration.

It would be better to use pelican's formatted date string. And for users who want different date format can use pelican's DEFAULT_DATE_FORMAT and DATE_FORMATS settings.

talha131 commented 10 years ago

@tshepang

I hope I did not come off as rude... the testing Comment.

Of course not! Especially when we are not native speakers of English :laughing:

tshepang commented 10 years ago

Given that the Category text would be on the far right, I doubt it would affect readability if you make the color more distinctive.

talha131 commented 10 years ago

Given that the Category text would be on the far right, I doubt it would affect readability.

Well it has to be responsive so it will definitely be near to title on small screens. I think we should use a slightly different shade of gray for category. This way category will appear bit differently than rest of the meta text.

Or we can give it a outline like this category. The same one that we use for tags in articles page.

tshepang commented 10 years ago

After checking my settings.py, I see I did set the date format:

DEFAULT_DATE_FORMAT = '%Y-%m-%d'

It does, however, appear that the current front page ignores that setting.

calfzhou commented 10 years ago

image

Does this look good?

tshepang commented 10 years ago

@talha131 what is articles page?

talha131 commented 10 years ago

what is articles page?

I meant the post page. Like your post "my favorite pelican themes".

talha131 commented 10 years ago

image Does this look good?

That's what i have in mind, except I want to make category link muted. See my comments here

calfzhou commented 10 years ago

My blog is http://www.gocalf.com/blog/, just updated the theme.

I add some custom styles, so it looks a little different with the default elegant theme. You could find my customizations here.

talha131 commented 10 years ago

My blog is http://www.gocalf.com/blog/, just updated the theme.

Awesome thank you!

calfzhou commented 10 years ago

That's what i have in mind, except I want to make category link muted.

Okay, i agree with you. I myself now find that two blue links on a single line looks ugly. :laughing:

tshepang commented 10 years ago

I also agree. I'd go with a shade of grey instead of different background color.

talha131 commented 10 years ago

What do you guys think of this?

screen shot 2013-11-24 at 8 12 43 pm

talha131 commented 10 years ago

I think this one is better and clearer, though it takes up two lines. It is easier to understand. Each info is placed separately from other.

Title Category and on right you have date.

I think date should appear on the right on the same line as category.

calfzhou commented 10 years ago

I think date should appear on the right on the same line as category.

Vote for this.

I think it's OK to use two lines. Still very clean.

tshepang commented 10 years ago

+1

talha131 commented 10 years ago

Hang on guys! I will push it out in next few minutes.

tshepang commented 10 years ago

@talha131 rocks!

tshepang commented 10 years ago

Did you forget to make the Category text distinctive?

talha131 commented 10 years ago

@tshepang @calfzhou

Please check now. Also check it on different screen sizes.

There is a bug which I cannot fix. It you change the browser window size to small. Date will appear under category. When you change the window size back to normal, date still appears on an empty line.

Otherwise this fix is good!

It does, however, appear that the current front page ignores that setting.

I think it should be fixed now. Let me know what you see @tshepang .

Did you forget to make the Category text distinctive?

Well if you hover over it, it changes its style. I figure this distinction is good enough.

tshepang commented 10 years ago

There is also an extra space between in and <tag name>:

screenshot from 2013-11-24 17 39 24

talha131 commented 10 years ago

Yeah, again its intentional. For distinction. I want to make sure all categories properly line up.

talha131 commented 10 years ago

There is a bug which I cannot fix. It you change the browser window size to small. Date will appear under category. When you change the window size back to normal, date still appears on an empty line.

This problem happens only on Chrome (I think Safari too will have the same issue). Any idea how to fix it?

tshepang commented 10 years ago

The date thing is fixed. Thanks.

talha131 commented 10 years ago

Great!

@calfzhou let me know what you think of it?

Also if you can fix the Chrome problem, it will be great.

calfzhou commented 10 years ago

This version of front page look great!

I guess the cause of date placement issue is that its display style is set to block.

tshepang commented 10 years ago

Given:

screenshot from 2013-11-27 23 26 29

talha131 commented 10 years ago

@tshepang Please open up new issues, even if it is related to some old issue. It is not difficult to reference old issues if you think it is necessary.

Separate issues makes my life a lot easier to assign labels, milestones, track progress and manage todo list.

Also, open and close status of an issue affects milestone progress bar, which is one, perhaps only, way to see progress of a release.

talha131 commented 10 years ago

Don't you guys feel that article title font size should be a bit larger than that of posted in Category?

On my dev machine, size of "posted in ____" is 13.8667px. Size of title is 15.4px. Do you have the same size on your machine?

See the computed section in element inspector. Please share those values here. It could be your system does not have the fonts that Elegant uses which will effect title size.

I also feel like the date is too far away from the associated Posts (on wide screens).

What do you propose? Please keep in mind the suggested style has to fit for users who have "About me" and "My projects" sections on top of recent posts.

isn't Recent Posts a little too large?

It is 38.5px here. What's your value?

besides being not capitalised, all posts does not look clickable.

Intentional! There is a big archive button at the top menu bar. If you hover over "all posts", cursor shape changes which is universal on all browsers to the best of my knowledge.

tshepang commented 10 years ago

I get the same Computed font size values.

talha131 commented 10 years ago

I get the same Computed font size values.

@tshepang the conversation has gotten jumbled up now. Lets start a new thread to keep it clean :necktie: