search

PelicanPlatform / docs

Pelican Docs
https://docs.pelicanplatform.org
MIT License
0 stars 2 forks source link

Download card improvement #23

Closed haoming29 closed 4 months ago

haoming29 commented 4 months ago

Closes #16 #17 #18

Screenshot 2024-05-23 at 9 45 20 AM Screenshot 2024-05-23 at 9 45 49 AM Screenshot 2024-05-23 at 9 45 38 AM
aowen-uwmad commented 4 months ago

Looks much better!

I'm partially inclined to group together rows with the same "Note". So for the Linux example, the first four rows would be for the downloads that don't have any notes, the next three would be the downloads with the OSDF note, and the last row would be the Server note. Of course, that would mess with the alphabetical ordering of the OS labels, which is why I'm only partially inclined.

On a related note (no pun intended), I'm not sure that "Note" is best label for that column. Maybe "Type" or "Variant"?

haoming29 commented 4 months ago

Looks much better!

I'm partially inclined to group together rows with the same "Note". So for the Linux example, the first four rows would be for the downloads that don't have any notes, the next three would be the downloads with the OSDF note, and the last row would be the Server note. Of course, that would mess with the alphabetical ordering of the OS labels, which is why I'm only partially inclined.

On a related note (no pun intended), I'm not sure that "Note" is best label for that column. Maybe "Type" or "Variant"?

I'm also unsure about grouping the variants together (or even being able to filter against them) but that's a good idea and I want to know how other folks think about this. For the name, I like Variant. Naming is always hard!