PelicanPlatform / pelican

The Pelican Platform for creating data federations
https://pelicanplatform.org/
Apache License 2.0
10 stars 24 forks source link

Add Pelican URL Parsing library to standardize how we handle pelican URLs #1589

Closed jhiemstrawisc closed 1 day ago

jhiemstrawisc commented 2 weeks ago

This new pelican_url package and its overall integration should feel like our beloved, familiar net/url package, but with some added niceties for Pelican URL parsing. In particular, it handles

A few caveats -- this grew more than I anticipated. The reviewer should pay particular attention to tests that I deleted -- in many cases, I moved the essence of the test to what I thought was a more appropriate location (such as within the pelican_url module), but there isn't a 1-1 relationship here. If I deleted something I shouldn't have, do let me know.

jhiemstrawisc commented 2 weeks ago

One to-do that came from a discussion with Brian -- go back through this and restore any exported APIs from the client to have the same signature. There were a few places where I changed whether a URL or a string were passed.

turetske commented 2 weeks ago

One to-do that came from a discussion with Brian -- go back through this and restore any exported APIs from the client to have the same signature. There were a few places where I changed whether a URL or a string were passed.

@jhiemstrawisc Shall I wait until this is done?

jhiemstrawisc commented 2 weeks ago

One to-do that came from a discussion with Brian -- go back through this and restore any exported APIs from the client to have the same signature. There were a few places where I changed whether a URL or a string were passed.

@jhiemstrawisc Shall I wait until this is done?

Probably a good idea for now, I think I'll have to adjust a few things that are non-trivial