PelicanPlatform / xrootd-s3-http

An XRootD plugin that allows Pelican to interface with s3/http server backends
Apache License 2.0
2 stars 6 forks source link

trailing / messes up signing of request #56

Open rw2 opened 1 week ago

jhiemstrawisc commented 1 week ago

@rw2, can you take another look at this? I think this fixes part of the issue with path-style lists, but it breaks regular GETs where we still need the object name in the generated URL (see failing tests).

On a side note, I think we still want to keep the list-type=2 and delimeter=/ query parameters here -- did you come to a different conclusion?

rw2 commented 1 week ago

Good news, now it's more than a one line fix!

Turned out there were two things. First the path'ing wasn't being done correctly. Second, once that was fixed, the correct paths were not being used in the correct places. So now that's fixed and the unit tests pass again.