search

PelionIoT / manifest-tool

A tool for creating and parsing update manifests
Apache License 2.0
10 stars 14 forks source link

Don't use pip internal API #2

Closed CristianPrundeanu closed 3 years ago

CristianPrundeanu commented 6 years ago

pip is not supported as a module API. In fact, the developers are actively trying to discourage everyone from using it this way. In pip v10, the entire pip.req was moved to pip._internal.req, thus breaking all scripts which imported it. This commit removes the need for pip.req.parse_requirements by using pure Python instead.

Reference: https://github.com/pypa/pip/issues/2286 Reference: https://github.com/pypa/pip/commit/95bcf8c5f6394298035a7332c441868f3b0169f4 Signed-off-by: Cristian Prundeanu cristian.prundeanu@arm.com

JanneKiiskila commented 4 years ago

@alzix - could this be reviewed?

alzix commented 3 years ago

the proposed change is no longer relevant/required