PelionIoT / manifest-tool

A tool for creating and parsing update manifests
Apache License 2.0
11 stars 14 forks source link

Release 2.6.0 #40

Closed jenia81 closed 11 months ago

jenia81 commented 1 year ago
jenia81 commented 1 year ago

@JanneKiiskila Please check the code scanning errors The logs are only for the certificate path, not its content And I wouldn't drop them since it helps with debugging

JanneKiiskila commented 1 year ago

@jenia81 - cleared false positives with comments. Resolved comments.

jenia81 commented 12 months ago

@JanneKiiskila dropped the cron job from the GitHub action It's a bit tricky to add the condition to the workflow I can add it before the steps like this: if: github.repository == 'PelionIoT/manifest-tool' && github.event.schedule != '0 0 */3 * *' But then the job will start its execution so the machine will be allocated, just the execution time will be shorter. The only way to make sure that it won't run at all is to create a difference between the workflow files in internal and public repos

JanneKiiskila commented 11 months ago

The only way to make sure that it won't run at all is to create a difference between the workflow files in internal and public repos

I think we will be fine with that.