Closed jenia81 closed 11 months ago
@JanneKiiskila Please check the code scanning errors The logs are only for the certificate path, not its content And I wouldn't drop them since it helps with debugging
@jenia81 - cleared false positives with comments. Resolved comments.
@JanneKiiskila dropped the cron job from the GitHub action
It's a bit tricky to add the condition to the workflow
I can add it before the steps like this:
if: github.repository == 'PelionIoT/manifest-tool' && github.event.schedule != '0 0 */3 * *'
But then the job will start its execution so the machine will be allocated, just the execution time will be shorter.
The only way to make sure that it won't run at all is to create a difference between the workflow files in internal and public repos
The only way to make sure that it won't run at all is to create a difference between the workflow files in internal and public repos
I think we will be fine with that.
--signing-tool
to themanifest-dev-tool init
command.--key
CLI option of themanifest-dev-tool init
command can receive an identifier private key or a private key file name that will be used to sign the manifest with the external signing tool provided.signing-tool
that is used by themanifest-tool create
command.--key
CLI option of themanifest-tool create
ormanifest-tool create-v1
command can receive an identifier private key or a private key file name that will be used to sign the manifest with the external signing tool provided.requests
to2.31.0
.cryptography
to41.0.4
.tox
additions etc.).dev-requirements
:pytest
to the latest7.4.2
.pylint
to2.17.7
(3.0.2
does not support older versions of Python).--force
CLI option that was deprecated already.