PelionIoT / mbed-cloud-client

Izuma Device Management Client library
https://izumanetworks.com
Apache License 2.0
43 stars 60 forks source link

mbed-os pal_crypto.h file name conflict with cloud-client file #75

Closed ladislas closed 3 years ago

ladislas commented 3 years ago

Description of defect

Note: this is a duplicate of https://github.com/ARMmbed/mbed-os/issues/13989 to track progress in mbed-cloud-client as well.

(cc @yannlocatelli)

This is the exact same issue as described in https://github.com/ARMmbed/mbed-os/issues/10022.

The issue was fixed in https://github.com/ARMmbed/mbed-os/pull/10042

But then the changes were reverted and the issue brought back with https://github.com/ARMmbed/mbed-os/pull/13217 and https://github.com/ARMmbed/mbed-os/commit/3e011a9c4ac8388bdd50256f961a564b832126b0

On the cloud client end, the PR mentioned by @adamelhakham (https://github.com/ARMmbed/mbed-os/issues/10022#issuecomment-471923066) is nowhere to be found.

Target(s) affected by this defect ?

Custom target with BLE and Pelion

Toolchain(s) (name and version) displaying this defect ?

arm-none-eabi-gcc --version
arm-none-eabi-gcc (GNU Arm Embedded Toolchain 9-2020-q2-update) 9.3.1 20200408 (release)

What version of Mbed-os are you using (tag or sha) ?

6.5.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

mbed --version
1.10.4

mbed-tools --version
3.5.1.dev36

How is this defect reproduced ?

Setup Pelion mbed-cloud-client using a target with BLE.

teetak01 commented 3 years ago

@ladislas could you provide the actual conflict you are seeing in the issue?

ladislas commented 3 years ago

We have the error message while compiling:

https://github.com/PelionIoT/mbed-cloud-client/blob/f72a23e0dc21de4c82ee53fe947153341419a5b9/mbed-client-pal/Source/PAL-Impl/Services-API/pal_Crypto.h#L22-L24

That is because both BLE and cloud-client have a file named pal_crypto.h

teetak01 commented 3 years ago

Internal ticket: https://armiot.atlassian.net/browse/IOTCLT-4603

teetak01 commented 3 years ago

will be fixed in 4.9.0 release.

teetak01 commented 3 years ago

@ladislas issue should be resolved now in https://github.com/PelionIoT/mbed-cloud-client/releases/tag/4.9.0

ladislas commented 3 years ago

Thanks a lot!