PelionIoT / mbed-coap

CoAP C library - Builder and Parser for CoAP messages
Apache License 2.0
29 stars 16 forks source link

Add block transfer status #52

Closed simosillankorva closed 6 years ago

simosillankorva commented 6 years ago
anttiylitokola commented 6 years ago

@simosillankorva, sn_coap_protocol unit tests are failing, could you check that one? 10:20:36 rm -f objs/sn_coap_protocol_unit/sn_coap_protocol.gcda objs/sn_coap_protocol_unit/main.gcda objs/sn_coap_protocol_unit/libCoap_protocol_test.gcda objs/sn_coap_protocol_unit/sn_coap_builder_stub.gcda objs/sn_coap_protocol_unit/sn_coap_parser_stub.gcda objs/sn_coap_protocol_unit/sn_coap_header_check_stub.gcda objs/sn_coap_protocol_unit/ns_list_stub.gcda objs/sn_coap_protocol_unit/randLIB_stub.gcda gcov_output.txt gcov_report.txt gcov_error.txt ; echo "Running sn_coap_protocol_unit_tests"; ./sn_coap_protocol_unit_tests -ojunit | tee sn_coap_protocol_unit_tests.txt 10:20:36 Running sn_coap_protocol_unit_tests 10:20:36 Segmentation fault (core dumped)

There is some Jenkins configuration issue since it still reports everything is ok.

anttiylitokola commented 6 years ago

rebuild

simosillankorva commented 6 years ago

Fixed the issue that caused the unit test to crash + added comments and tried to clarify the code.

yogpan01 commented 6 years ago

@artokin @terhei Can you check if this change is ok with CoAP service for Thread as well ?

terhei commented 6 years ago

CoAP service does not support blockwise, so this is OK.