PelionIoT / mbed-coap

CoAP C library - Builder and Parser for CoAP messages
Apache License 2.0
29 stars 16 forks source link

Fix handling of duplicate blockwise ACK's #75

Closed anttiylitokola closed 5 years ago

anttiylitokola commented 5 years ago

CoAP data buffer was not added into duplication info store when creating response for blockwise request. This leads to case where whole bootstrap flow just timeouts if received any duplicate messages during blockwise operation.

Fixes error: IOTCLT-3188 - UDP connection fails for lost ACK sending

anttiylitokola commented 5 years ago

That's true there is no e2e test cases to verify duplicate message handling. That is not even possible with the mock at the moment. We need to somehow be able to skip ACK sending but don't know how to do that other than adding some code changes and testing just locally. Delaying the network is also one way to do it but not possible to automate at the moment.