Add support for FOTA combined image

PelionIoT / mbed-edge

Edge Core

https://izumanetworks.com

Apache License 2.0

25 stars 32 forks source link

Add support for FOTA combined image #67

Closed davidsaada closed 3 years ago

davidsaada commented 3 years ago

This PR starts the support for FOTA combined image for edge. This now includes the rootfs installation and verification callbacks, where the rest of rootfs callbacks (rollback, finalize) and all bootloader callbacks still need implementation.

This includes the following:

Replace fota_install_callbacks module with fota_app_callbacks, which includes all FOTA related callbacks (including the ones previously used for FOTA).
Use external defines for install script directory and file.
Add relevant defines in makefile if FOTA_COMBINED_IMAGE_SUPPORT is set.

davidsaada commented 3 years ago

@ygoyal18 @petedyerarm Comments addressed, please re-review.

whygoyal commented 3 years ago

I am able to recreate the PR check error on my local machine. For some reason, when you compile parsec_se_driver with new version of cargo 1.55.0, its failing to link the library. Its working with older version of cargo like 1.52.0.

petedyerarm commented 3 years ago

I am able to recreate the PR check error on my local machine. For some reason, when you compile parsec_se_driver with new version of cargo 1.55.0, its failing to link the library. Its working with older version of cargo like 1.52.0.

What determines the version of cargo to be used?

davidsaada commented 3 years ago

@ygoyal18 Is it OK to merge this PR, as CI errors are unrelated?

whygoyal commented 3 years ago

Yes, I agree that these changes are not responsible for PR checks failure. I am trying to find a quick solution to the problem, looks like some environment configuration issue. If not resolved in 24 hours, I will merge this PR.

@petedyerarm This is where its downloading the latest available cargo and rustc - https://github.com/PelionIoT/edge-ci/blob/98cd81fc016f0ea3ca283a675805c919218a2409/vars/repoMbedEdge.groovy#L82 . Quick solution would be to lock down the version to 1.52.0.