search

PelionIoT / mbed-trace

mbed trace library
Apache License 2.0
18 stars 15 forks source link

Add FEA_TRACE_SUPPORT flag as an option to enable tracing. #20

Closed tommikas closed 8 years ago

tommikas commented 8 years ago

@jupe

jupe commented 8 years ago

@kjbracey-arm @SeppoTakalo could you check this out

kjbracey commented 8 years ago

Seems reasonable to me - if mbed_trace.h is acting as a replacement for ns_trace.h, FEA_TRACE_SUPPORT is the macro we seem to be using, with HAVE_DEBUG being deprecated. There should indeed be some non-Yotta-branded selection method.

There are still people using HAVE_DEBUG, mind. Although I'm fine with losing that - the name is unhelpful.

jupe commented 8 years ago

lgtm but lets wait feedback from @SeppoTakalo before merging

tommikas commented 8 years ago

@SeppoTakalo Could you take a look at this please.

SeppoTakalo commented 8 years ago

+1 I'm ok with the change. When we take the mbed-trace library into use, we can replace the HAVE_DEBUG flag with the FEA_TRACE_SUPPORT.