search

PelionIoT / mbed-trace

mbed trace library
Apache License 2.0
18 stars 15 forks source link

Hotfix #36

Closed jupe closed 8 years ago

jupe commented 8 years ago

merging fixes from master

note: unit tests is not working in release branch, just for note..

@tommikas @kjbracey-arm @yogpan01 @teetak01

tommikas commented 8 years ago

Should ARMmbed/mbed-trace#31 perhaps get in too? Although I'm not sure which builds it fixes exactly.

kjbracey commented 8 years ago

Does it fix the library order problem?

kjbracey commented 8 years ago

Hard to tell - no commit message.

tommikas commented 8 years ago

It doesn't seem to. I'm not sure what application and problem it fixes exactly. Asked Jaakko for elaboration but he's probably left the office by now. (Still green on slack though, so I'm not sure.)

jupe commented 8 years ago

I merged that #31 to master, but could it cause problems I'm not sure. Perhaps we shouldn't merge it to release branch

jupe commented 8 years ago

maybe we should merge this and update version #37 and do yotta publish, ok?

teetak01 commented 8 years ago

Jaakko's fix would seem to work. Tested quickly.

tommikas commented 8 years ago

I take that back. It does seem to fix it.

teetak01 commented 8 years ago

This is still missing Jaakko's fix?

teetak01 commented 8 years ago

As in this alone will not fix the build issues.

jupe commented 8 years ago

now it's included in this PR -> going to release branch

jupe commented 8 years ago

ready to merge ? @kjbracey-arm @yogpan01

teetak01 commented 8 years ago

builds linux-example + linux-tests work fine with this.