Make stoip6 return whether the conversion succeed (fix a bug from #72)

PelionIoT / nanostack-libservice

Other

2 stars 11 forks source link

Make stoip6 return whether the conversion succeed (fix a bug from #72) #74

Closed Taiki-San closed 6 years ago

Taiki-San commented 6 years ago

This pull request fix a bug introduced in the refactor of #72. We could drive len to 0 within the loop and decrement it once too many with the for loop. This pull request fix the issue and add a new unit test case.

It appears unlikely the previous unit tests would have run with the old code, so no new radically different unit test appear to be necessary.

I don't have the infrastructure to run the tests on my machine, so could someone have a go?

kjbracey commented 6 years ago

Please rebase, making sure you adjust the new "prefix" function to return your new return value.

Taiki-San commented 6 years ago

Can I get the detail of the failure?

artokin commented 6 years ago

I'm sorry, this was my mistake. All needed pieces were not merged to our CI. They are merged now and CI job is re-triggered.

Taiki-San commented 6 years ago

@kjbracey-arm do you think this PR need anything else?