search

PelionIoT / simple-mbed-cloud-client

Simple interface for Mbed Cloud Client - deprecated
Apache License 2.0
7 stars 21 forks source link

Fixed compilation issues (#47, #50) #51

Closed andrewc-arm closed 5 years ago

andrewc-arm commented 5 years ago

Hi, I compared code between simple-mbed-cloud-client and mbed-cloud-client-example and merged in the necessary build code/conf files to enable compilation. This fixes the problem of

Please review and let me know your opinion.

andrewc-arm commented 5 years ago

Hi, @screamerbg I see. Then could you please show me how I can compile SPDMC test? From the code as we have, when I compiile I get the issues of #47 and #50. Or am I missing something? :)

andrewc-arm commented 5 years ago

Hi, @screamerbg

Now I see where the problem is. simple-mbed-cloud-client should not simply be added as 'mbed add' and test. There are missing files and those are already in https://github.com/ARMmbed/smcc-tests. I think we need to either improve the documentation in this library to run with simple 'mbed add' or ask people to review 'smcc-tests' for actual SPDMC testing hands on. The current documentation of this github is quite misleading and caused me to dug down to make file structures similar to 'smcc-tests'.

What's your opinion?

Thanks,

MarceloSalazar commented 5 years ago

I'd like the idea of simplifying the SMCC application even more and help people to get started asap.

What if we pick the empty symbols from update_default_resources.c and define them as weak in the SMCC library?

This file will be created in the application when calling mbed dm init to enable FW update.

andrewc-arm commented 5 years ago

No need for this PR to proceed. I referenced K64F and made https://os.mbed.com/teams/Sigma-Delta-Technologies/code/pelion-example-common/ It's working well.