PelletierConstructionGroup.github.io_6_19_Copy-CSS-from-Houzz

JoyZhang2023 commented 5 months ago

Resolves #28 Copy CSS from Houzz for below pages.

[x] projects.html
[x] testimonials.html
[x] projects/6871419-timber-frame-barn.html
[x] projects/6871428-mukilteo-house.html
[x] projects/6871440-open-concept-kitchen.html
[x] projects/6871444-ranch-home-update.html
[x] projects/6871446-bathroom-expansion.html
[x] projects/6871458-great-wall-of-lake-city.html
[x] projects/7167797-wrap-around-deck-with-patio-cover.html
[x] projects/7167805-composite-deck.html
[x] projects/7167814-modern-porch.html
[x] projects/7167820-new-shop.html
[x] projects/7167823-railing.html
[x] projects/7167828-bathroom.html

This pull request is to extract css from existing Houzz page and add it to our repo so that we can use it with direct link. 1 new css files were add for stylesheet while inline styles are kept. All pages layout remains.

Ali-7s commented 5 months ago

The navbar styling for index.html and the other main pages seems to be different

Index:

Projects:

About:

JoyZhang2023 commented 5 months ago

@Ali-7s Thanks for your feedback. Somehow my preview works fine on Home page and other pages. Index page:

Could you please try now and see if it's fixed?

taylorpapke commented 5 months ago

@JoyZhang2023 What is going on with this PR? The pages are looking like @heosman's screenshot on my end as well.

JoyZhang2023 commented 5 months ago

@heosman @taylorpapke All page render fine on my end. If you open the html directly, the css file couldn't render due to use of relative path link. I'm using Live Preview extension to check the page preview in VS code. Please let me know if it helps.

taylorpapke commented 5 months ago

@heosman @taylorpapke All page render fine on my end. If you open the html directly, the css file couldn't render due to use of relative path link. I'm using Live Preview extension to check the page preview in VS code. Please let me know if it helps.

I downloaded Microsoft Live Preview extension but am still getting the same result. Is there something else I'm missing here?

JoyZhang2023 commented 5 months ago

@heosman @taylorpapke All page render fine on my end. If you open the html directly, the css file couldn't render due to use of relative path link. I'm using Live Preview extension to check the page preview in VS code. Please let me know if it helps.

I downloaded Microsoft Live Preview extension but am still getting the same result. Is there something else I'm missing here?

The preview works fine. Only the code seems off. Could you switch to my branch (copy-css-style-from-houzz) and run the preview again?

taylorpapke commented 5 months ago

It is your branch:

JoyZhang2023 commented 5 months ago

It is your branch:

The same file on my end renders fine. I noticed that the recent commit on your side shows 5 days ago. There're more commits 4 days ago on 5/11/24. Could you check the commit history? There should be 8 commits. If the problem persist, I'm create a new branch to test out. Maybe I used the same branch name which was merged before.

taylorpapke commented 5 months ago

Oh, so you just have to push the changes on your branch? That should update this PR.

heosman commented 5 months ago

@heosman @taylorpapke All page render fine on my end. If you open the html directly, the css file couldn't render due to use of relative path link. I'm using Live Preview extension to check the page preview in VS code. Please let me know if it helps.

@JoyZhang2023 I also installed the Microsoft Live Preview Extension and am still experiencing the same problem, like @taylorpapke. I am running the preview from the copy-css-style-from-houzz branch. I noticed from your screenshot that our URLs looks different. Might this be the problem?

I removed the "PelletierConstructionGroup.github.io" from the paths to the css files and it seems to be rendering properly now.

JoyZhang2023 commented 5 months ago

@heosman @taylorpapke All page render fine on my end. If you open the html directly, the css file couldn't render due to use of relative path link. I'm using Live Preview extension to check the page preview in VS code. Please let me know if it helps.

@JoyZhang2023 I also installed the Microsoft Live Preview Extension and am still experiencing the same problem, like @taylorpapke. I am running the preview from the copy-css-style-from-houzz branch. I noticed from your screenshot that our URLs looks different. Might this be the problem?

I removed the "PelletierConstructionGroup.github.io" from the paths to the css files and it seems to be rendering properly now.

@heosman Thank you!! You're right. I used relative path for css file so that it links correctly between files. And your url is different than my end. The github folder directory is not necessary on your end as your're running it from workspace directly and I'm running it from folder inside workspace. @taylorpapke In that case, would you like me to update the css file path to direct file name? Should be a quick update.

taylorpapke commented 5 months ago

@JoyZhang2023 Yes, please update. Thanks!

JoyZhang2023 commented 5 months ago

@JoyZhang2023 Yes, please update. Thanks!

@taylorpapke Got it. Working on it. Give me 20 minutes.

JoyZhang2023 commented 5 months ago

@heosman @taylorpapke css file paths have been updated on all files. Please check if it renders fine.

PelletierConstructionGroup / PelletierConstructionGroup.github.io

PelletierConstructionGroup.github.io_6_19_Copy-CSS-from-Houzz #45