search

Peltoche / ical-rs

Rust parser for ics (rfc5545) and vcard (rfc6350)
Apache License 2.0
110 stars 21 forks source link

Adding ical-Output #39

Closed migmedia closed 3 years ago

migmedia commented 3 years ago

Hi,

I have needed the ability to output some ics-files. Maybe it's helpfull to others?

migmedia

mohe2015 commented 3 years ago

@Peltoche Do you think this would have the potential to get merged?

ModProg commented 3 years ago

Is there any progress on merging this?

Peltoche commented 3 years ago

Hello everyone, sorry for the delay.

I didn't have much time for open-source lately. I will try to check this today and I hope I will be able to release it too.

Peltoche commented 3 years ago

Hi,

Everything looks good to me. A big thanks @migmedia for this contribution :+1: .

Could you rebase this branche please? Once this is done I will merge it and create a new release.

migmedia commented 3 years ago

Could you rebase this branche please? Once this is done I will merge it and create a new release.

Due to the merge (370d9db ) caused by a conflict in Cargo.toml rebasing would change history and destroy the clones of this repository. Or do I misunderstand you?

Peltoche commented 3 years ago

You need to rebase your master on top mine and resolve the conflict between the two in order to keep your new commits on top of my HEAD and be able to push them. This will make some changes in your last commits on your master. I you don't want that you can make a new branche on your side and make the changes on this branche. Once you fork a repo you need to keep up with the new reviews if you want to be able to merge.

migmedia commented 3 years ago

Created a new branch on master/HEAD and started a new pull-request.