PencilCode / pencilcode

An online IDE for kids: pencilcode.net.
http://dev.pencilcode.net/
MIT License
167 stars 100 forks source link

Use `html2canvas` to assist thumbnail generation. #155

Closed xinan closed 9 years ago

xinan commented 9 years ago

Note: I reverted the camera button because it turns out to be more complicated than I thought. There are several severe bugs that needs to be solved.

xinan commented 9 years ago

I wonder why one of the Travis threads fails.

xinan commented 9 years ago

@davidbau Could we sort out the test problem and get this merged first? Let's skip the camera button for this PR. I'm having another branch for that.

davidbau commented 9 years ago

OK. (The tests are still failing for me after we get rid of v10 etc.)

xinan commented 9 years ago

:tada: It passed after re-running.

davidbau commented 9 years ago

In this PR, what version of html2canvas is brought in? Since we're not using npm to install it, did you add it to bower.json so that grunt update updates it?

davidbau commented 9 years ago

This is very nice work. I like how the test is solid green now. I left a couple other comments.

xinan commented 9 years ago

Okay updated with response to all the suggestions above :smile:

davidbau commented 9 years ago

Looks great. Merging!