Closed xinan closed 9 years ago
I wonder why one of the Travis threads fails.
@davidbau Could we sort out the test problem and get this merged first? Let's skip the camera button for this PR. I'm having another branch for that.
OK. (The tests are still failing for me after we get rid of v10 etc.)
:tada: It passed after re-running.
In this PR, what version of html2canvas is brought in? Since we're not using npm
to install it, did you add it to bower.json
so that grunt update
updates it?
This is very nice work. I like how the test is solid green now. I left a couple other comments.
Okay updated with response to all the suggestions above :smile:
html2canvas
into bower.json
and grunt bowercopy
.style.display
settings of the nodes that we are going to hide, and restore them when we are done capturing thumbnails.Looks great. Merging!
html2canvas
and use the old thumbnail functions to do cropping and resizing.Note: I reverted the camera button because it turns out to be more complicated than I thought. There are several severe bugs that needs to be solved.