search

PencilCode / pencilcode

An online IDE for kids: pencilcode.net.
http://dev.pencilcode.net/
MIT License
167 stars 100 forks source link

Directory view toggle icon is wrong. #213

Open dinukadesilva opened 8 years ago

dinukadesilva commented 8 years ago

image

image

xinan commented 8 years ago

What do you mean by wrong? I guess this is subject :sweat_smile: If you percept it as the current display mode, it is correct. If you perceive it as an action button, it is wrong.

If i remember correctly, this behaves just like the similar switch in Windows Explorer, which displays the current display mode, instead of the mode that it would trigger. Personally I think this is more intuitive. But ideas are welcome :blush:

dinukadesilva commented 8 years ago

ah............If that is the case, it's correct

But, I felt like it's a switch since it's a button.

dinukadesilva commented 8 years ago

Don't you feel like it's better if it's a switch. I mean.............

In windows explorer, it has a drop down, and showing the selected mode.

But, if you check in google drive or gmail, the same implementation is there as a switch. And also, when it's a button, I think it should show what's it's action more than it's status. :blush:

xinan commented 8 years ago

Hmm, now both way seems fine to me :flushed:

I guess the reason why I would consider it as status is because this button does not has borders. When you hover on it, it does not show borders to indicate that it is an action, whereas Google Drive does that.

Let's see what @davidbau thinks.