search

Penecruz / VAICOMPRO-Community

VAICOM PRO for DCS World
MIT License
163 stars 25 forks source link

[BUG] App Fails Silently if VoiceAttack has previously been installed but is not currently #111

Closed wrycu closed 9 months ago

wrycu commented 9 months ago

Describe the bug Installing and launching Vaicom Pro without VoiceAttack installed results in a blinking icon appearing in the system tray and nothing else happening.

To Reproduce Install VoiceAttack, then uninstall it. Install Vaicom Pro. Note that no warning that VoiceAttack is not installed is presented and it successfully installs.

Expected behavior Vaicom Pro should warn that VoiceAttack is not currently installed, as it does if the registry keys are manually deleted (or if it was never installed.)

Screenshots If applicable, add screenshots to help explain your problem.

Additional context For what it's worth, I have VoiceAttack via steam. I do not know if this happens with a standalone version.

Penecruz commented 9 months ago

Hi there, this bug is more to do with the fact that when Voice Attack is uninstalled it leaves it's folder structure in place. VaicomPro will check that the Voice Attack/apps folder is present on install.

This behaviour of Voice Attack is probably by design to ensure user profiles and apps are not deleted when voice attack is uninstalled and reinstalled.

If you subsequently install voice attack again with a VaicomPro.dll in the apps folder it will work as it is supposed to.

Given that VaicomPro is a plug-in for Voice Attack it would make sense it does not function without the primary software installed.

Thanks for the report, however I believe the behaviour is as intended.

wrycu commented 9 months ago

I don't believe "working as intended" is correct. You get a warning if you attempt to install Vaicom without ever having installed VoiceAttack - why is the logic any different if you've previously installed VoiceAttack? There could be years between the events.

In the end, "it's too much work" is a totally fine stance to take - I totally understand you're doing this in your free time. But again, I don't believe "working as intended" is correct when there's a warning if you've never installed it (the intent of which is clearly to warn if it's not installed, not if it's never been installed.)

In any case, thanks for the work, reply, and kindly-worded response. I do appreciate it all.