PengNi / deepsignal2

GNU General Public License v3.0
26 stars 4 forks source link

deepsignal2 vs deepsignal ? #1

Closed pterzian closed 3 years ago

pterzian commented 3 years ago

Hi Peng,

Glad to see a new version of deepsignal ! I have some questions:

Best, Paul

PengNi commented 3 years ago

Hi Paul,

Best, Peng

pterzian commented 3 years ago

Thank you for these answers. I am trying to understand if I can use features files extracted with the first version of deepsignal to train a model with deepsignal2. Or, call previously extracted features with your new model. I see you made some modifications to the features format and I would like to be sure of what I understood. From these lines of code :

https://github.com/PengNi/deepsignal2/blob/2136cb258f156046ac7163f6dfd257ca09891d28/deepsignal2/extract_features.py#L316

https://github.com/PengNi/deepsignal2/blob/2136cb258f156046ac7163f6dfd257ca09891d28/deepsignal2/call_modifications.py#L69

I understand you split the raw signal of one base with , and sets of raw signal with ; ?

If 1 base = 3 signal values it would be written out like this :

0.0,0.0,0.0;0.0,0.0,0.0;etc

Is this the only change between both features format file ?

PengNi commented 3 years ago

Yes, it's the only change. In deepsignal, we extract at most 360 signal values centered in the raw signals of 17mer; in deepsignal2, we extract at most 16 signals of each base, to form 17*16 matrix.

Best, Peng