Update lambda functions in security/__init__py to def functions + 3 changes

Pengin-Open-Source / pengin-pi

PENGIN PI! A CRM with the back bone of a feature light ERP system. Utilitarian in design, easy to extend, customize, and deploy. Made by a community, supported by Tobu Pengin.

GNU General Public License v3.0

9 stars 1 forks source link

Update lambda functions in security/initpy to def functions + 3 changes #410

Closed franfif closed 5 months ago

franfif commented 7 months ago

Update lambda function to def function in utils/security/init.py (was marked as TODO in code)
Correct the edit_ticket_need and edit_ticket_comment_need declarations to use the right arguments
Add .idea to .gitignore to account for pyCharm's project files
Add flask version <3.0.0 as using the last version of flask led to dependencies issues

stuart909 commented 5 months ago

The merge wasn't clean. I'm going to sleep on this one. We are going to go to LDAP soon and I don't want to refactor other parts of the code, potentially... So this may not be needed.

franfif commented 5 months ago

There's multiple things in here, do you want me to divide everything in single PRs?

franfif commented 5 months ago

Closing this pull request:

Too many issues in this PR
Conflicting files
File .gitignore has already been updated
File requirements.txt has already been updated
Creating new PRs for lambda functions refactoring and edit ticket needs typo correction

Pengin-Open-Source / pengin-pi

Update lambda functions in security/__init__py to def functions + 3 changes #410

Update lambda functions in security/initpy to def functions + 3 changes #410