search

Pengin-Open-Source / pengin-pi

PENGIN PI! A CRM with the back bone of a feature light ERP system. Utilitarian in design, easy to extend, customize, and deploy. Made by a community, supported by Tobu Pengin.
GNU General Public License v3.0
9 stars 1 forks source link

[TASK] Message class event handling modification #417

Closed stuart909 closed 5 months ago

stuart909 commented 6 months ago

Description The message class message_json method needs to be split into two methods

Details

Additional context

416

franfif commented 6 months ago

send_message() method will be requested by a user after a user transmits This method is called by the Messenger.save_message() method on the server side, to streamline the process:

Initial design, as proposed in the original issue: Client: method Messenger.send_message() -> emit socketIO event "save_message" Server: event listener for "save_message": Messenger.save_message() -> emit event "message_saved" Client: event listener for "message_saved" -> emit event "get_message" Server: event listener for "get_message": Messenger.send_message() -> emit event "saved_message" Client: event listener for "saved_message" -> call client function create_message() to update div with message

Design as committed Client: method Messenger.send_message() -> emit socketIO event "save_message" Server: event listener for "save_message": Messenger.save_message() -> call Messenger.send_message() method Server: method Messenger.send_message() -> emit event "saved_message" Client: event listener for "saved_message" -> call client function create_message() to update div with message

This way, we avoid an unnecessary back and forth with the server and the client.

franfif commented 6 months ago

I modified the code in the pengin-pi repo, but as all development has been moved to messenger repo, I don't think I should do a pull request at this time.