PenguLoader / PenguLoader

✨ The ultimate JavaScript plugin loader, build your unmatched LoL Client.
https://pengu.lol
Do What The F*ck You Want To Public License
346 stars 56 forks source link

a bug due to null value #99

Closed pzx521521 closed 5 months ago

pzx521521 commented 5 months ago

i use it success but when i reopen "LeagueClientUx.exe", active_status display off(but it work). when i change the active_status , it report a bug like follow bug


i find the reason:

in \HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Image File Execution Options\LeagueClientUx.exe if can create "LeagueClientUx.exe" but not "Debugger" because of UnauthorizedAccessException it will be use SymlinkMode success but if i reopen Pengu Loader.exe, active_status will show off, if i want not use Pengu Loader, i can't change it to off


so I added a non-empty critique if dont add old != null, code will run here:


            catch
            {
                // if dont add `old != null`, code will run here and  caused a bug
                // TODO: handle some other errors
            }
nomi-san commented 5 months ago

Thank you, but you have forked the stable branch. I just changed to a separate fix branch and will merge it into dev later.