PenguinMod / PenguinMod-Home

A main dashboard page featuring community projects and featured content.
https://penguinmod.com
23 stars 53 forks source link

Utilize a Different Scratch Auth Frontend. #20

Open Steve0Greatness opened 1 year ago

Steve0Greatness commented 1 year ago

Hey! I'm aware of this project's relative popularity in the Scratch modding space. I'm also aware that PenguinMod uses the default provided front-end of Scratch Auth for authentication. This, on it's own, is not a problem. What is a problem, however, is that people frequently spam the comments section of Looky(the creator, owner, and primary-maintainer of Scratch Auth) with comments relating to issues they face while using PenguinMod.

I don't think anyone should be spammed, I hope you agree with me. Which is why I'm requesting that you stop using the unmodified front-end of Scratch Auth without changing it to make it clear that this project is not affiliated with Scratch Auth.

What Do I Mean By "Front-End"

Scratch Auth works with it's own backend API, an API that just happens to have CORs enabled, meaning it can be accessed from anywhere by both JS code, and backend JS code. It's API is pretty ok-ly documented, although you have to do some digging. I already did this digging.

* = required

Based off of this image of a forum post on the original Scratch Auth Forum Topic(before it got dustbinned).

RedMan13 commented 1 year ago

people frequently spam the comments section of Looky

how would we fix this

RedMan13 commented 1 year ago

and also how would we edit the front end of scratch auth?

RedMan13 commented 1 year ago

nvm ignore the second and the first one comment

JeremyGamer13 commented 1 year ago

there are a lot of long tasks related to the API so unfortunately this isn't gonna be able to happen soon

Ianyourgod commented 1 year ago

i think this is a good idea, ive seen that comment section. But as JG said we have other problems

Steve0Greatness commented 1 year ago

i think this is a good idea, ive seen that comment section. But as JG said we have other problems

there are a lot of long tasks related to the API so unfortunately this isn't gonna be able to happen soon.

That's fair. I just thought it'd be smart to bring this to yall's attention, as well as give details that could help solve it.

Steve0Greatness commented 11 months ago

I'm currently implementing this, see Steve0Greatness/PenguinMod-Home:auth for progress. I'll make a PR when I finish it, and make it look nicer.

JeremyGamer13 commented 11 months ago

if you ever finish it please mention me once its done so i can tell our translators to help translate it 👍

I'm currently implementing this, see Steve0Greatness/PenguinMod-Home:auth for progress. I'll make a PR when I finish it, and make it look nicer.

Steve0Greatness commented 11 months ago

Alright, I'll let you know. Also, it's functionally almost done; I basically just need to add the "done" function.

Steve0Greatness commented 11 months ago

It is (functionality wise) done. But it's not done in the looks department. Also, I cannot test it right now, because the project servers are down.

Steve0Greatness commented 11 months ago

@JeremyGamer13, I believe it's ready to be translated. Should I open a PR with maintainer contributions enabled?

JeremyGamer13 commented 11 months ago

yea, maybe mark as draft

Steve0Greatness commented 11 months ago

yea, maybe mark as draft

Alright!

Steve0Greatness commented 11 months ago

yea, maybe mark as draft

A PR has been made now.