Remove unnecessary code & refactor code

Axorax commented 10 months ago

nvm, formatted incorrectly, do not merge

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
penguinmod-home	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 20, 2024 4:39am

JeremyGamer13 commented 10 months ago

this just seems like you ran an auto formatter on the whole repo with the wrong settings so the indenting size is wrong

RedMan13 commented 10 months ago

Works properly as before but now the code is much cleaner and I also removed some unnecessary code in the index file (+page.svelte)

what "unecesary code" was removed....

RedMan13 commented 10 months ago

ok so there is ALOT wrong with this commit (including the fact that it doesnt seem to remove any code :trollface:)

while i understand that the current home page code may look like garbag (and performs like it too) that is at the fault of the way it is made not the formating of the code
two-space tab width reads horribly compared to four-space tab width
isnt it "DOCTYPE" and not "doctype"?
a minor nitpick of mine is the usage of " instead of ', wich just kinda looks wrong
another nitpick is the replacement of * inside of the markdown files
having a trailing , on objects just looks bad and having inconsistent quotes around value names in objects looks ugly, including when no keys in the object require it and there added anyways
removing whitespace that aligns two separate columns of information is just bad and unhelpfull
lowercase hexcodes look bad

that is my heavily opinionated assessment of this commit TL,DR exactly what jeremy said :trollface:

Ianyourgod commented 10 months ago

" superiority!!!! ' bad!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

RedMan13 commented 10 months ago

" superiority!!!! ' bad!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

but its look like bad kinda old and more keystrokes to type :grr

PenguinMod / PenguinMod-Home