search

Penlect / rectangle-packer

Rectangle packing program
MIT License
62 stars 16 forks source link

Fix building with Cython3 #21

Closed arcondello closed 9 months ago

arcondello commented 10 months ago

Closes https://github.com/Penlect/rectangle-packer/issues/20. Turns out that's not actually an ARM error, but rather a Cython3 one.

I have tested this change with both Cython 0.29.36 and Cython 3.0.0

JunkyByte commented 10 months ago

Can confirm it builds successfully on Cython 3 and Cython 0.29.36 on a M2 Macbook, thanks!

arcondello commented 10 months ago

@Penlect , any chance you could take a look at this one?

Penlect commented 10 months ago

Thanks guys for investigating this. I don't have any Apple hardware myself unfortunately. I need to build new wheels for this, but I noticed that the CI-job fails in its current form. I will try to take a look at this during the weekend.

arcondello commented 10 months ago

Thanks!

arcondello commented 9 months ago

Hi @Penlect sorry to ping you again - I am sure you have other stuff on your plate. Any chance for an update? Anything I can help with?

Penlect commented 9 months ago

Hi, sorry, yeah I failed to figure out why the CI-job is failing for macos-11:

    OSError: [Errno 66] Directory not empty: '/Users/runner/work/rectangle-packer/rectangle-packer/.eggs/Cython-3.0.2-py3.9-macosx-10.9-x86_64.egg/Cython-3.0.2.dist-info' -> '/Users/runner/work/rectangle-packer/rectangle-packer/.eggs/Cython-3.0.2-py3.9-macosx-10.9-x86_64.egg/EGG-INFO'
    error: subprocess-exited-with-error

and this is basically blocking me from uploading new wheels.

arcondello commented 9 months ago

@Penlect seems to be https://github.com/cython/cython/issues/5568, I could open a PR upper bounding the Cython version or could just wait for that to resolve.