search

Penlect / rectangle-packer

Rectangle packing program
MIT License
62 stars 16 forks source link

Use the latest cibuildwheel #23

Open arcondello opened 9 months ago

arcondello commented 9 months ago

Also use the latest build dependencies to avoid build errors.

I can't actually trigger the CI runs, but I think this should resolve the build errors seen in https://github.com/Penlect/rectangle-packer/pull/21#issuecomment-1731990526. See also https://github.com/cython/cython/issues/5568, https://github.com/pypa/cibuildwheel/issues/1612

arcondello commented 9 months ago

Nope, unfortunately using the latest cibuildwheel and setuptools does not seem to resolve it. Closing.

arcondello commented 9 months ago

Ok, I ended up also requiring Cython<3.0.0. I am not totally satisfied with this because https://github.com/Penlect/rectangle-packer/pull/21 means that the code works with Cython 3, but for the purpose of unblocking deployments this should hopefully be good enough.

@Penlect any chance you can take a look?

Penlect commented 9 months ago

Hi @arcondello , thank you for suggesting adding Cython<3.0.0. That successfully resolved the build errors I was encountering. Updated wheel packages are now available on PyPI, including support for Python 3.12, as a bonus. The next step is to figure out what changes are required to successfully build for Cython>=3.0.0.