PennLINC / aslprep

Preprocessing of arterial spin labeling (ASL) data
https://aslprep.readthedocs.io
Other
41 stars 15 forks source link

Improve error messages in ReduceASLFiles #379

Closed tsalo closed 11 months ago

tsalo commented 11 months ago

Closes none, but should make the error messages that could be raised by ReduceASLFiles more informative.

I noticed some related errors in the Sentry logs for this week.

Changes proposed:

codecov-commenter commented 11 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d6c868c) 78.98% compared to head (780cfcd) 78.90%.

Files Patch % Lines
aslprep/interfaces/utility.py 50.00% 1 Missing and 1 partial :warning:
aslprep/utils/asl.py 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ========================================== - Coverage 78.98% 78.90% -0.08% ========================================== Files 39 39 Lines 4149 4153 +4 Branches 602 604 +2 ========================================== Hits 3277 3277 - Misses 676 678 +2 - Partials 196 198 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 11 months ago

test_001 may not have the necessary metadata for SyN:

Traceback:
        Traceback (most recent call last):
          File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/interfaces/base/core.py", line 397, in run
            runtime = self._run_interface(runtime)
          File "/usr/local/miniconda/lib/python3.10/site-packages/sdcflows/interfaces/epi.py", line 57, in _run_interface
            self._results["readout_time"] = get_trt(
          File "/usr/local/miniconda/lib/python3.10/site-packages/sdcflows/utils/epimanip.py", line 228, in get_trt
            raise ValueError("Unknown total-readout time specification")
        ValueError: Unknown total-readout time specification