search

PennLINC / fw-heudiconv

Heuristic-based Data Curation on Flywheel
BSD 3-Clause "New" or "Revised" License
6 stars 11 forks source link

[BUG] dataset_description.json values get overwritten if they exist #57

Closed mattcieslak closed 4 years ago

mattcieslak commented 4 years ago

https://github.com/PennBBL/fw-heudiconv/blob/2b6214cc5b2cf398a794c22b1e92c0ddbf6aa09e/fw_heudiconv/convert.py#L315

TinasheMTapera commented 4 years ago

Haha yeah....... I remember wondering whether or not people would have defaults and I leaned on no... time to update

TinasheMTapera commented 4 years ago

This should be solved here https://github.com/PennBBL/fw-heudiconv/blob/dc36e76d057ab9113afde3d42ecd11777a936955/fw_heudiconv/convert.py#L313