PennLINC / qsiprep

Preprocessing of diffusion MRI
http://qsiprep.readthedocs.io
BSD 3-Clause "New" or "Revised" License
140 stars 58 forks source link

Remove underscore versions of all parameters #861

Closed tsalo closed 1 week ago

tsalo commented 2 weeks ago

Closes none. This is a breaking change because parameter names have effectively been changed.

Changes proposed in this pull request

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.57%. Comparing base (0e21c37) to head (6ab3975).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #861 +/- ## ======================================= Coverage 28.57% 28.57% ======================================= Files 68 68 Lines 10126 10126 Branches 1135 1135 ======================================= Hits 2893 2893 Misses 7134 7134 Partials 99 99 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 2 weeks ago

Oh you're right! I might have corrected in the wrong direction. Do you have any issue with me reversing this and dropping the underscore versions?

mattcieslak commented 2 weeks ago

I trust the fmriprep folks on this decision

tsalo commented 2 weeks ago

Okay cool, I'll reverse my changes.