search

PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Draft pre-init ingression #102

Open tsalo opened 2 weeks ago

tsalo commented 2 weeks ago

Just a template for integrating @smeisler's ingression package.

Changes proposed in this pull request

Documentation that should be reviewed

tsalo commented 2 weeks ago 
The conflict is caused by:
    qsirecon 0.1.dev50+gfb6bacf depends on nibabel<=5.2.0
    ingress2qsirecon 0.1.0 depends on nibabel<6.0.0 and >=5.2.1
The conflict is caused by:
    qsirecon 0.1.dev679+g60e4cea.d20240830 depends on nilearn==0.10.1
    ingress2qsirecon 0.1.0 depends on nilearn<0.11.0 and >=0.10.4
smeisler commented 2 weeks ago

None of my versions pinned for ingress2qsirecon are strictly necessary, so if it would be easier for you if I change it to match qsiprep/recon, let me know.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 19.51220% with 33 lines in your changes missing coverage. Please review.

Project coverage is 33.73%. Comparing base (361e27f) to head (0df2933).

Files with missing lines Patch % Lines
qsirecon/cli/parser.py 24.00% 16 Missing and 3 partials :warning:
qsirecon/workflows/base.py 0.00% 13 Missing :warning:
qsirecon/workflows/recon/anatomical.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== + Coverage 33.68% 33.73% +0.04% ========================================== Files 56 56 Lines 6937 6856 -81 Branches 910 901 -9 ========================================== - Hits 2337 2313 -24 + Misses 4496 4438 -58 - Partials 104 105 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 2 weeks ago

Now that tests are passing, @smeisler do you want to take over this PR and add any tests you might want?