PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Rename `--freesurfer-input` to `--fs-subjects-dir` #152

Closed tsalo closed 1 week ago

tsalo commented 1 week ago

Closes #45 and closes #139.

Changes proposed in this pull request

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (4495e9d) to head (95825cb).

Files with missing lines Patch % Lines
qsirecon/workflows/recon/anatomical.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== - Coverage 33.53% 33.52% -0.02% ========================================== Files 57 57 Lines 7117 7115 -2 Branches 965 965 ========================================== - Hits 2387 2385 -2 Misses 4628 4628 Partials 102 102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 1 week ago

Good question. I just looked and SUBJECTS_DIR isn't used anywhere except for the FreeSurferIngressTest.sh file.