search

PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Remove unused preprocessing-specific code #3

Closed tsalo closed 3 months ago

tsalo commented 6 months ago

Summary

The code that is only used by QSIPrep needs to be removed.

tsalo commented 3 months ago

@mattcieslak can I remove all of qsirecon.workflows.anatomical, qsirecon.workflows.dwi, and qsirecon.workflows.fieldmap?

mattcieslak commented 3 months ago

I'm not sure about this because I am thinking maybe they could be useful if we wanted to further process some of the ingressed anatomical data?

tsalo commented 3 months ago

We can always add the workflows back in if they're useful, but my guess is that further anatomical processing would be better done by importing workflows from niworkflows or smriprep.

mattcieslak commented 3 months ago

agreed. Let's remove them

tsalo commented 3 months ago

The one workflow from anatomical that QSIRecon needs is init_output_grid_wf and I started importing that one from QSIPrep.