PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Collect templates from TemplateFlow instead of package data #49

Closed tsalo closed 1 month ago

tsalo commented 1 month ago

Closes #48.

Changes proposed in this pull request

tsalo commented 1 month ago

We'll want to cache the downloaded templates in the build image so users aren't downloading them at runtime.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (c80616e) to head (757df18).

Files Patch % Lines
qsirecon/interfaces/anatomical.py 72.72% 6 Missing :warning:
qsirecon/workflows/recon/anatomical.py 0.00% 4 Missing :warning:
qsirecon/workflows/base.py 0.00% 1 Missing :warning:
qsirecon/workflows/reports.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ========================================== + Coverage 33.42% 33.52% +0.10% ========================================== Files 56 56 Lines 6825 6824 -1 Branches 894 891 -3 ========================================== + Hits 2281 2288 +7 + Misses 4446 4438 -8 Partials 98 98 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 1 month ago

I'm a little surprised this actually worked, since it uses AFNI's 3dResample, but I thought the only thing from AFNI that we were keeping in the Docker image was 3dAutobox?

tsalo commented 1 month ago

@mattcieslak does this look good to merge now?