PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Add ng, perng, parng, and mapcoeffs to Dipy MAPMRI outputs #55

Closed tsalo closed 3 months ago

tsalo commented 3 months ago

Closes #54.

Changes proposed in this pull request

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (0995156) to head (2dd0989).

Files Patch % Lines
qsirecon/interfaces/dipy.py 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================== - Coverage 33.28% 33.25% -0.04% ========================================== Files 56 56 Lines 6780 6787 +7 Branches 888 889 +1 ========================================== Hits 2257 2257 - Misses 4432 4439 +7 Partials 91 91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 3 months ago

I haven't tried it but I will this morning.

tsalo commented 3 months ago

I had to modify make_sloppy, but yeah they're getting written out.

mattcieslak commented 3 months ago

All set to merge then?

tsalo commented 3 months ago

Yup!