Closed tsalo closed 2 months ago
Attention: Patch coverage is 48.52941%
with 35 lines
in your changes missing coverage. Please review.
Project coverage is 33.75%. Comparing base (
e780ae1
) to head (bcd8bcd
).
Files | Patch % | Lines |
---|---|---|
qsirecon/workflows/base.py | 12.50% | 28 Missing :warning: |
qsirecon/interfaces/utils.py | 66.66% | 4 Missing :warning: |
qsirecon/interfaces/reports.py | 75.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The summary reportlets are being written to the output_dir
rather than individual QSIRecon pipeline directories. I could either move the reportlet generation to the individual pipelines' workflows or copy any reportlets to the pipeline directories. I'm leaning toward the latter.
@mattcieslak do you think QSIRecon should write out the recon spec? It seems useful.
@mattcieslak do you think QSIRecon should write out the recon spec? It seems useful.
Definitely. It's at least as important as the config.toml file
I add that in then
Okay it's added and it looks good.
Related to #13. Still missing run-wise anatomical and DWI summaries.
Changes proposed in this pull request