PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Add summary reportlets to HTML report #61

Closed tsalo closed 2 months ago

tsalo commented 2 months ago

Related to #13. Still missing run-wise anatomical and DWI summaries.

Changes proposed in this pull request

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 48.52941% with 35 lines in your changes missing coverage. Please review.

Project coverage is 33.75%. Comparing base (e780ae1) to head (bcd8bcd).

Files Patch % Lines
qsirecon/workflows/base.py 12.50% 28 Missing :warning:
qsirecon/interfaces/utils.py 66.66% 4 Missing :warning:
qsirecon/interfaces/reports.py 75.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== + Coverage 33.52% 33.75% +0.22% ========================================== Files 56 56 Lines 6824 6852 +28 Branches 891 892 +1 ========================================== + Hits 2288 2313 +25 Misses 4438 4438 - Partials 98 101 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 2 months ago

The summary reportlets are being written to the output_dir rather than individual QSIRecon pipeline directories. I could either move the reportlet generation to the individual pipelines' workflows or copy any reportlets to the pipeline directories. I'm leaning toward the latter.

tsalo commented 2 months ago

@mattcieslak do you think QSIRecon should write out the recon spec? It seems useful.

mattcieslak commented 2 months ago

@mattcieslak do you think QSIRecon should write out the recon spec? It seems useful.

Definitely. It's at least as important as the config.toml file

tsalo commented 2 months ago

I add that in then

tsalo commented 2 months ago

Okay it's added and it looks good.