search

PennLINC / qsirecon

Reconstruction of preprocessed q-space images (dMRI)
https://qsirecon.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Fix QSIRecon Entrypoint #76

Closed smeisler closed 2 months ago

smeisler commented 2 months ago

Fixes #75

tsalo commented 2 months ago

I think you might need to move

derivatives/qsirecon-PYAFQ/sub-ABCD/dwi/sub-ABCD_acq-10per000_space-T1w_dwimap/bundles/sub-ABCD_acq-10per000_coordsys-RASMM_trkmethod-probCSD_recogmethod-AFQ_desc-LeftSuperiorLongitudinal_tractography.trk
derivatives/qsirecon-PYAFQ/sub-ABCD/dwi/sub-ABCD_acq-10per000_space-T1w_dwimap/viz_core_bundles/sub-ABCD_acq-10per000_coordsys-RASMM_trkmethod-probCSD_recogmethod-AFQ_desc-LeftSuperiorLongitudinalviz_dwi.html

to the list of optional outputs.

tsalo commented 2 months ago

You'll need to remove those files from the required inputs as well, since they were expected but not found.

smeisler commented 2 months ago

passing tests now, okay to merge?

mattcieslak commented 2 months ago

What happened in the pyafq outputs? Were some of the files in the wrong list?

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.75%. Comparing base (6fde41c) to head (db89131). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ======================================= Coverage 33.75% 33.75% ======================================= Files 56 56 Lines 6852 6852 Branches 892 892 ======================================= Hits 2313 2313 Misses 4438 4438 Partials 101 101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattcieslak commented 2 months ago

I missed the earlier conversation, looks good to me!