search

Penneo / sdk-net

Apache License 2.0
4 stars 17 forks source link

Don't use .Result but do proper await #155

Closed burningice2866 closed 1 year ago

burningice2866 commented 2 years ago

Don't use .Result but do proper async await

https://github.com/Penneo/sdk-net/blob/ae2803c07e129f489facdd4d82c9d90178a272d8/Src/Penneo/RestConnector.cs#L36

danneforslund commented 1 year ago

This change is bound to make deadlocks happen when the SDK is called from UI threads, Blazor, etc. Please review, or as @burningice2866 said, implement proper Async()-methods throughout the whole SDK.

danneforslund commented 1 year ago

Much appreciated! 👍