search

PennockTech / smtpdane

SMTP DANE testing tool
MIT License
22 stars 1 forks source link

DNS resolver iteration is always using all resolvers #5

Closed philpennock closed 1 year ago

philpennock commented 1 year ago

While the issue in #4 was accurate, it shouldn't have been seen because the DNS resolver shouldn't have been used. So a real issue was reported, but it is a bug that it was found to be reported.

Adding a debug to the resolver iteration inner loop, just before the exchange, shows we hit all the resolvers. This should not be.

philpennock commented 1 year ago

Fixed in 5a8751fe1061aa06f7862f6a3bde06737000d923

The bad status check is because I have abysmal test coverage for this repo. No way is this leaving a v0 major until coverage testing is much better. :(

philpennock commented 1 year ago

(this is in the v0.4.4 release)