search

PennyDreadfulMTG / Penny-Dreadful-Tools

A suite of tools for the Penny Dreadful MTGO community
https://pennydreadfulmagic.com
MIT License
39 stars 28 forks source link

Some of the rules that are globally suppressed in our flake8 config would be good to enable #11213

Open bakert opened 1 year ago

bakert commented 1 year ago

Not line-length, but some of them.

bakert commented 2 months ago

E302 - Two blank lines between classes. E402 - Imports not at top of file E713 - Test for membership should be 'not in' W503 - No line break before binary operator W504 - No line break after binary operator

(and not E501 - line length)

bakert commented 2 months ago

I cleaned up E713, W504 and W503 as they were relatively simple.

We have 1368 violations of E302 (two blank lines) and I don't even know if it's nice, really. But perhaps we should join the standard.

There are only a few violations of E402 but they are functional changes not just lint changes.