search

PennyDreadfulMTG / Penny-Dreadful-Tools

A suite of tools for the Penny Dreadful MTGO community
https://pennydreadfulmagic.com
MIT License
40 stars 28 forks source link

Old league and all competition pages should say what season they are from #12357

Open bakert opened 6 months ago

bakert commented 6 months ago

They already "know" because they show the right banner but they should be slightly more contextualized? For decks the "legal" section tells you what season they were legal in but that's not quite enough because (a) some decks are legal in more than one season, and (b) a handful decks are not legal in their own season (!)

bakert commented 6 months ago

Seasonized URLs to them should work and we should decide which is cnaonical and Moved Permanently from the other.

bakert commented 6 months ago

I seasonized all links in competitions, decks and leaderboards in a4e9a32.

bakert commented 6 months ago

The banner shows the right thing. And all links go to the right places. But unlike on something like /cards there is no season drop down to give you a visual indicator what season this deck comes from. There IS a legal section which will mostly just contain the season it was legal in BUT sometimes it contains more than one season, and occasionally it contains a different season but those decks are rare enough we don't care too much.

bakert commented 6 months ago

The situation for competitions is even worse as they don't have a legal section.