search

PennyDreadfulMTG / Penny-Dreadful-Tools

A suite of tools for the Penny Dreadful MTGO community
https://pennydreadfulmagic.com
MIT License
41 stars 28 forks source link

"1 Perfect Run Crushes" should be "Crush" #4992

Closed vorpal-buildbot closed 6 years ago

vorpal-buildbot commented 6 years ago

Reported on Discord by bakert#2193

bakert commented 6 years ago

Most of the achievements (entry/entries, win/wins, etc.) need this treatment.

bakert commented 6 years ago

This is one of those things that's complicated by i18n. Do we have anything for plurals right now?

bakert commented 6 years ago

http://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html

bakert commented 6 years ago

This seems to be what we are doing:

self.active_runs_text = ngettext('%(num)d active league run', '%(num)d active league runs', len(active_runs))

and the i18n system copes with that.

bakert commented 6 years ago

It would be nice to use inflect's plural features but that would probably break i18n.

bakert commented 6 years ago

79b42df5.