search

PennyDreadfulMTG / Penny-Dreadful-Tools

A suite of tools for the Penny Dreadful MTGO community
https://pennydreadfulmagic.com
MIT License
41 stars 28 forks source link

When someone uses /add/ to add a url without http(s) on the front we get a nice error message in the resulting exception but show a 500 error to them. at the very least we should 200 with an error message #5119

Closed vorpal-buildbot closed 6 years ago

vorpal-buildbot commented 6 years ago

Reported on Discord by bakert#2193

bakert commented 6 years ago

Invalid URL 'tappedout.net/mtg-decks/daxos-auras-pd-commander/?fmt=printable': No schema supplied. Perhaps you meant http://tappedout.net/mtg-decks/daxos-auras-pd-commander/?fmt=printable?

bakert commented 6 years ago 
Invalid URL 'tappedout.net/mtg-decks/daxos-auras-pd-commander/?fmt=printable': No schema supplied. Perhaps you meant http://tappedout.net/mtg-decks/daxos-auras-pd-commander/?fmt=printable?

Reported on decksite by eternalparadox38```
--------------------------------------------------------------------------------
Request Method: POST
Path: /add/?
Cookies: {'__cfduid': 'ddaae571137995bb77df4a0dd0f274e3e1512313198', '_ga': 'GA1.2.502867344.1512313211', 'hide_intro': 'True', 'session': '.eJx1kF9rgzAUxb_LfZahUWP0bX3oYNC_Y67rGJJqtFJjYhJpXel3XxS2wmBvufece8_N7wqZZIrTlrUGEqN65gAteN1CUtJG26qodS5UkdUFJICCyCcowoigOPRQ5IbgwP9KI3LaMKuydqqqihVjnhbttI94yAFuKpH1mqmW8slrxmcjqaKFuPjETgramyPKtKFmdHQLjFMdr8q31zASq0AeQ1NHKaEvX7PT4e434mSDkyvQPGda_9Qgn9YXuR9SudsW52065Dxf-8OijodzuIvsPLvIWjGdUcvECxFGHg4weYgiFASE3PURE3YD4roOKFba1vE35KA3j5vnXZzSbrnvlnMev-N9yjtO_XnIbYjFKu1vPiw_C78uB9ur-ropNHw6MK3JzDBaYMaoYgpuDvyFZ6iqmL2y7Zvm9g1lUpRI.Dkk-4Q.U44O7YLo0XcIK88fbX6I-JVlPcY', 'deck_id': '19896', '_gid': 'GA1.2.463211397.1533242058', '_gat_gtag_UA_109131120_1': '1'}
Endpoint: add_deck
View Args: {}
Person: 247382762829512705
Referrer: https://pennydreadfulmagic.com/add/
Request Data: {'url': 'tappedout.net/mtg-decks/daxos-auras-pd-commander/'}
Host: pennydreadfulmagic.com
Accept-Encoding: gzip
Cf-Ipcountry: US
X-Forwarded-For: 64.136.209.218, 108.162.216.192
Cf-Ray: 445df359af3c5534-ORD
X-Forwarded-Proto: https
Cf-Visitor: {"scheme":"https"}
Cache-Control: max-age=0
Origin: https://pennydreadfulmagic.com
Upgrade-Insecure-Requests: 1
Content-Type: application/x-www-form-urlencoded
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,/;q=0.8
Referer: https://pennydreadfulmagic.com/add/
Accept-Language: en-US,en;q=0.9
Cookie: __cfduid=ddaae571137995bb77df4a0dd0f274e3e1512313198; _ga=GA1.2.502867344.1512313211; hide_intro=True; session=.eJx1UG1rgzAQ_i_3WYZGjbHf1g8dDPo65rqOIamJNlRNTCKtK_3vi4WtMNi3u3te7u65AGWNaGFS0tpwD5gwhdQsFwwmgKIkJCjBiKA0DlDix-DB_0gtq4qzXHFtZHtzIAHyoLGVzHvDdUsb7rTcjmWtqKZMnkPilJL29oByY6kdGd0c48yky_LtNU7kMlKH2IokI_Tla3rc3_lWHrk7_QK0KLgxPz2op9VZ7YZMbTfstMmGoilW4TAX6XCKt4nT87MSmpucWpgEMcIowBEmD0mCooiQOz4Gg_2I-L4HmpdudPhdsjfrx_XzNs1ot9h1i1mTvuNd1nQNDWdx45a4IJX75sMlxlsrysHNql7UzMCnBzeb3A4jBaacaq7h6sHf8CzVFXdXtn1dX78BxpqJhA.DfcsNg.FQkGPgnsy7R0enGP1lkfmT7kAWU; deck_id=19896; _gid=GA1.2.463211397.1533242058; _gat_gtag_UA_109131120_1=1; session=.eJx1kF9rgzAUxb_LfZahUWP0bX3oYNC_Y67rGJJqtFJjYhJpXel3XxS2wmBvufece8_N7wqZZIrTlrUGEqN65gAteN1CUtJG26qodS5UkdUFJICCyCcowoigOPRQ5IbgwP9KI3LaMKuydqqqihVjnhbttI94yAFuKpH1mqmW8slrxmcjqaKFuPjETgramyPKtKFmdHQLjFMdr8q31zASq0AeQ1NHKaEvX7PT4e434mSDkyvQPGda_9Qgn9YXuR9SudsW52065Dxf-8OijodzuIvsPLvIWjGdUcvECxFGHg4weYgiFASE3PURE3YD4roOKFba1vE35KA3j5vnXZzSbrnvlnMev-N9yjtO_XnIbYjFKu1vPiw_C78uB9ur-ropNHw6MK3JzDBaYMaoYgpuDvyFZ6iqmL2y7Zvm9g1lUpRI.Dkk-4Q.U44O7YLo0XcIK88fbX6I-JVlPcY
Cf-Connecting-Ip: 64.136.209.218
X-Forwarded-Host: pennydreadfulmagic.com
X-Forwarded-Server: pennydreadfulmagic.com
Connection: Keep-Alive
Content-Length: 59

--------------------------------------------------------------------------------
MissingSchema
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2309, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/cache.py", line 71, in decorated_function
response = make_response(f(*args, **kwargs))
File "./decksite/main.py", line 173, in add_deck
deck_id = decksite.scrapers.tappedout.scrape_url(url).id
File "./decksite/scrapers/tappedout.py", line 90, in scrape_url
raw_deck.update(parse_printable(raw_deck)) # type: ignore
File "./decksite/scrapers/tappedout.py", line 103, in parse_printable
s = fetcher_internal.fetch(raw_deck['url'] + '?fmt=printable')
File "./shared/fetcher_internal.py", line 46, in fetch
response = SESSION.get(url, headers=headers)
File "/home/discord/.local/lib/python3.6/site-packages/requests/sessions.py", line 525, in get
return self.request('GET', url, **kwargs)
File "/home/discord/.local/lib/python3.6/site-packages/requests/sessions.py", line 498, in request
prep = self.prepare_request(req)
File "/home/discord/.local/lib/python3.6/site-packages/requests/sessions.py", line 441, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/home/discord/.local/lib/python3.6/site-packages/requests/models.py", line 309, in prepare
self.prepare_url(url, params)
File "/home/discord/.local/lib/python3.6/site-packages/requests/models.py", line 383, in prepare_url
raise MissingSchema(error)
silasary commented 6 years ago

As far as I'm aware, the only user of that page is the discord bot.

silasary commented 6 years ago

looking closer at chat error report... I guess I'm wrong. That's a human using it.

On Thu., 9 Aug. 2018, 15:31 Katelyn Gigante, notifications@github.com wrote:

As far as I'm aware, the only user of that page is the discord bot.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PennyDreadfulMTG/Penny-Dreadful-Tools/issues/5119#issuecomment-411641517, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL2zraemc7VJdHqXhtR5Gy1GH6nKJnLks5uO8kmgaJpZM4VwzFI .

bakert commented 6 years ago

d9259e05.