/person/achievements should be /people/achievements and loads data in the view instead of in the controller

PennyDreadfulMTG / Penny-Dreadful-Tools

A suite of tools for the Penny Dreadful MTGO community

https://pennydreadfulmagic.com

MIT License

39 stars 28 forks source link

/person/achievements should be /people/achievements and loads data in the view instead of in the controller #5654

Closed vorpal-buildbot closed 5 years ago

vorpal-buildbot commented 5 years ago

Reported on Discord by bakert#2193

bakert commented 5 years ago

Or just /achievements to avoid potential mtgo username conflicts

adambiltcliffe commented 5 years ago

Moved to /achievements/, but it may still be desirable to move some of the code. Possibly wait until the end of the current glut of achievement-related PRs and see what we've ended up with?

bakert commented 5 years ago

I did the rest of this in 015e45. It probably bears review (and debate?) by interested parties.