Closed vorpal-buildbot closed 5 years ago
Otherwise known as "old-style". We use these numerals in parts of the site but the application is not quite consistent and not quite right. I'm not even sure the current state of affairs is better than just not using old style numerals. But Practical Typography and The Elements of Typographic Style both tell me I need them and who am I to argue? Modern numerals do stick out like a sore thumb in all-lowercase'd mtgo usernames for starters.
Right now the rules we have are:
p, .subtitle, .news .item {
font-variant-numeric: oldstyle-nums;
}
table, ul.decklist.li, .news .date {
font-variant-numeric: normal;
}
This is trying to represent "in body text/all-lowercase use lowercase nums, in titles/title text use uppercase nums". But it's only partly correct.
Current:
Proposed:
I think it is better. I'm not completely sure why the small caps variant of the font isn't doing this in the first place.
I've set anywhere using heading-caps (the all-small-caps font used in table headings and links) to use oldstyle-nums. And it might be a bit nutty but I've wrapped every use of MTGO username I can find in .person class so I can apply it there too, even in headings. We'll see how it feels
Not:
And:
Not:
Slight awkwardness – because the code for the page title/banner is shared I had to put the person class on all h1 headings. We'll see if this bites us anywhere.
450e0189 (HEAD -> blitz) Wrap all uses of mtgo username in a .person class to lowercase numberals. 67576930 Use oldstyle numbers wherever we are using small caps.
Reported on Discord by bakert#2193