PennyDreadfulMTG / Penny-Dreadful-Tools

A suite of tools for the Penny Dreadful MTGO community
https://pennydreadfulmagic.com
MIT License
41 stars 28 forks source link

Move parse_line and similar functions for dealing with text decklists out of decksite.scrapers and into magic #5789

Closed vorpal-buildbot closed 5 years ago

vorpal-buildbot commented 6 years ago

Reported on Discord by acidicrhyme#5579

adambiltcliffe commented 6 years ago

admin.py wants to import this functionality because the rules page uses it for the include/exclude lists, and importing it from decksite.scrapers is clearly not the right thing to be doing.

bakert commented 6 years ago

Personally I would move all of decksite.scrapers.decklist into magic. It's all generic/not scraper or decksite specific. Moderately surprised you didn't just pass your text into decklist.parse but I guess it's a bit weird to get back a 'maindeck' and a 'sideboard'.

bakert commented 5 years ago

2832cf7a.