search

PennyLaneAI / PennyLane-IonQ

This PennyLane plugin allows IonQ simulators/hardware to be used as PennyLane devices.
https://docs.pennylane.ai/projects/ionq
Apache License 2.0
10 stars 12 forks source link

enable partially entangling ms gates #101

Closed splch closed 6 months ago

splch commented 6 months ago

adds a third parameter for the ms gate that defaults to 0.25 (fully entangling). can be changed to enable partial entanglement.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.06%. Comparing base (a7d2d30) to head (8094647).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #101 +/- ## ========================================== - Coverage 96.85% 96.06% -0.80% ========================================== Files 5 5 Lines 318 330 +12 ========================================== + Hits 308 317 +9 - Misses 10 13 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

splch commented 6 months ago

thanks! i appreciate the suggestion too :)

trbromley commented 6 months ago

Thanks @splch! Looks like it's nearly there, but missing a test that passes the theta parameter. Are you able to add that in?

splch commented 6 months ago

Thanks @splch! Looks like it's nearly there, but missing a test that passes the theta parameter. Are you able to add that in?

hi! thanks for the feedback :) is this what you were thinking of for theta testing? https://github.com/PennyLaneAI/PennyLane-IonQ/pull/101/files#diff-72107d6f4a703abaeb6a7cf709e0c99f7ed0b7c74f0b14b0cbc4f35c7c650e26R369-R389

Alex-Preciado commented 6 months ago

Thank you so much for this contribution @splch !! We have double checked and the Codecov failures seem unrelated to the changes made in this PR. Force merging now!! 🚀