PennyLaneAI / catalyst

A JIT compiler for hybrid quantum programs in PennyLane
https://docs.pennylane.ai/projects/catalyst
Apache License 2.0
142 stars 36 forks source link

[BUILD SYSTEM] Remove zstd #1291

Closed erick-xanadu closed 2 weeks ago

erick-xanadu commented 2 weeks ago

Context: We do not want to ship zstd.

Description of the Change: Removes zstd from LLVM build process.

Benefits: No zstd.

Possible Drawbacks: Possibly our bytecode takes more space.

Related GitHub Issues:

We will need to remove all caches for this change to take into effect.

github-actions[bot] commented 2 weeks ago

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md on your branch with:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.95%. Comparing base (75dc517) to head (94e6713). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1291 +/- ## ========================================== + Coverage 96.72% 97.95% +1.23% ========================================== Files 56 77 +21 Lines 6800 11318 +4518 Branches 780 981 +201 ========================================== + Hits 6577 11087 +4510 - Misses 173 181 +8 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erick-xanadu commented 2 weeks ago

https://github.com/PennyLaneAI/catalyst/actions/runs/11729023698 these wheels do not contain zstd. The cache must be purged for this change to take effect.

rmoyard commented 2 weeks ago

What was the reason to set it to FORCE_ON?

erick-xanadu commented 2 weeks ago

Do we know the size difference of the wheels with this change?

@mlxd : Looks like just 1 MB. It could have been more if we removed both zlib and zstd. But keeping zlib makes the difference very small.