search

PennyLaneAI / catalyst

A JIT compiler for hybrid quantum programs in PennyLane
https://docs.pennylane.ai/projects/catalyst
Apache License 2.0
130 stars 29 forks source link

[MLIR] Re-enable multithreaded compilation in MLIR #466

Open erick-xanadu opened 8 months ago

erick-xanadu commented 8 months ago

This is a trivial change. Instead of having a call to ctx.disableMultiThreading() call ctx.enableMultiThreading(). To close this ticket, we should also clean up the printing infrastructure. At the very least, CatalystIRPrinterConfig's definition should be deleted as it is no longer used. Please also delete the comment. The way printing is done has changed and the comment is outdated.

https://github.com/PennyLaneAI/catalyst/blob/c559403ed836c4d20564712430dc751af77f9724/mlir/lib/Driver/CompilerDriver.cpp#L409-L411

josh146 commented 8 months ago

@erick-xanadu do you have more context here for this issue?

erick-xanadu commented 8 months ago

@josh146 there was originally an issue with the printing mechanism. Looking a little bit closer, it looks like the error is no longer there. If I remember correctly, the issue was with CatalystIRPrinterConfig but this struct is no longer used since October 13. So, I think this can be an easy fix / cleanup of code.

josh146 commented 8 months ago

Thanks! do you mind updating the original comment in the issue with the full context?